Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build image fails for python if requirements.txt doesn't exist #693

Closed
StephenWeatherford opened this issue Dec 10, 2018 · 4 comments
Closed
Assignees
Labels

Comments

@StephenWeatherford
Copy link
Contributor

StephenWeatherford commented Dec 10, 2018

See PR #647

@StephenWeatherford
Copy link
Contributor Author

@brettcannon, @lloydchang I would rather show (or document) best practice first, and have it be convenient second. Does it make sense to only supply the requirements.txt file to install if it exists? Or is it better to supply it always and document that users should create it? Or something else? Thanks!

@brettcannon
Copy link
Member

Since this is Docker who knows what the person did at a different layer 😉 . So if you don't have a requirements.txt file then skipping the running of python3 -m pip is fine as I would assume/hope you got your dependencies into the image in some other way.

@StephenWeatherford StephenWeatherford self-assigned this Jan 16, 2019
@StephenWeatherford StephenWeatherford added this to the 0.6.0 milestone Jan 16, 2019
@StephenWeatherford
Copy link
Contributor Author

Probably should make no changes. need to follow up.

@StephenWeatherford
Copy link
Contributor Author

@brettcannon, @lloydchang Sounds like the best policy is to leave things as they are and let the user modify if they need to. Closing for now, but feel free to re-open if you have a different suggestion. Thx.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 3, 2019
@ejizba ejizba removed this from the 0.6.0 milestone May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants