Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect docker-compose.override.yml by default #569

Closed
jmdfm opened this issue Oct 17, 2018 · 2 comments
Closed

Respect docker-compose.override.yml by default #569

jmdfm opened this issue Oct 17, 2018 · 2 comments
Assignees
Milestone

Comments

@jmdfm
Copy link

jmdfm commented Oct 17, 2018

This may be related to #379 and #261.

The default canonical behavior of the docker-compose command line tool is that if you have a docker-compose.override.yml file, when running docker-compose up it will look at your docker-compose.yml and then docker-compose.override.yml file as well, automatically. Nothing more needs to be specified via switches, it just works.

What this extension currently does is to specify the -f flag bye default for whatever selected compose file is being targeted, breaking the automatic inclusion of docker-compose.override.yml and producing an unexpected experience.

I feel this is a separate issue from people using docker-compose.whatever.yml files, as those would have to be specified in order with the -f flag to docker-compose anyway.

I'd propose that the default behavior of this extension's docker-compose up command should be to look for the presence of a docker-compose.override.yml file, and if it's present append a -f docker-compose.override.yml to the command arguments.

I suggest this because it seems more straightforward to implement this than dealing with VSCode's current inability to determine what the order between a larger collection of docker-compose.whatever.yml files should be - in the case above we know that the order is always -f docker-compose.yml -f docker-compose.override.yml.

Implementing that behavior will bring this extension into line with how the docker-compose command line tool works, reducing unexpected and confusing behaviour, and allows breaking off the bigger task hinted at in #379 and #261 of handling general collections of .yml files or making -f be optional to a later date.

@StephenWeatherford StephenWeatherford added this to the 0.5.0 milestone Oct 24, 2018
@ejizba ejizba modified the milestones: 0.7.0, 0.8.0 Jun 18, 2019
@BigMorty BigMorty modified the milestones: 0.9.0, 0.10.0 Sep 18, 2019
@BigMorty BigMorty modified the milestones: 0.10.0, 0.11.0 Dec 4, 2019
@dbreshears dbreshears added the P2 label Feb 7, 2020
@ravipal
Copy link
Contributor

ravipal commented Feb 25, 2020

Fixed by #1603

@bwateratmsft
Copy link
Collaborator

Hey @johnmcdowall , this is now available in Docker extension version 1.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants