Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of SELinux relable options #3656

Closed
bwateratmsft opened this issue Oct 18, 2022 · 2 comments · Fixed by #3586
Closed

Removal of SELinux relable options #3656

bwateratmsft opened this issue Oct 18, 2022 · 2 comments · Fixed by #3586
Labels
feature
Milestone
1.23.0

Comments

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Oct 18, 2022 •
edited
Loading

As part of the move to use the Docker CLI, we're using the mount syntax, which does not support SELinux relabling. I'm creating this issue to make a note that the corresponding options for docker-run tasks are being removed.

It's worth noting Docker Inc kinda recommends against using the ,z options.
@bwateratmsft bwateratmsft added this to the 1.23.0 milestone Oct 18, 2022
@bwateratmsft bwateratmsft linked a pull request Oct 18, 2022 that will close this issue
Use Docker CLI only #3586
Merged
64 tasks
@bwateratmsft
Copy link
Collaborator Author

A better practice is available here. In short, set the labeling on the host directly, rather than asking the Docker daemon to do it via the ,z option.

@bwateratmsft bwateratmsft self-assigned this Oct 18, 2022
@bwateratmsft bwateratmsft removed their assignment Oct 21, 2022
@bwateratmsft
Copy link
Collaborator Author

This has now been released in Docker extension version 1.23.0.

@microsoft microsoft locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.23.0
Development

Successfully merging a pull request may close this issue.

Use Docker CLI only microsoft/vscode-docker
1 participant
@bwateratmsft