Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failures in registry listing to telemetry #358

Closed
StephenWeatherford opened this issue Aug 6, 2018 · 3 comments
Closed

Add failures in registry listing to telemetry #358

StephenWeatherford opened this issue Aug 6, 2018 · 3 comments
Labels

Comments

@StephenWeatherford
Copy link
Contributor

e.g. this:

    if (loggedIntoAzure) {
        const subs: SubscriptionModels.Subscription[] = this.getFilteredSubscriptions();

        const subPool = new AsyncPool(MAX_CONCURRENT_SUBSCRIPTON_REQUESTS);
        let subsAndRegistries: { 'subscription': SubscriptionModels.Subscription, 'registries': ContainerModels.RegistryListResult }[] = [];
        //Acquire each subscription's data simultaneously
        // tslint:disable-next-line:prefer-for-of // Grandfathered in
        for (let i = 0; i < subs.length; i++) {
            subPool.addTask(async () => {
                const client = new ContainerRegistryManagement(this.getCredentialByTenantId(subs[i].tenantId), subs[i].subscriptionId);
                let regs: ContainerModels.Registry[];
                try {
                    regs = await client.registries.list();
                    subsAndRegistries.push({
                        'subscription': subs[i],
                        'registries': regs
                    });
                } catch (error) {
                    vscode.window.showErrorMessage(error); <<<<<<<<<<
@StephenWeatherford
Copy link
Contributor Author

Another possibility would be to add error nodes.

@estebanreyl
Copy link

Ill add these to the telemetry right now. Additionally, I quite like the errorNode idea, you mentioned an azuretreedataprovider in #360 , should we wait until that is added before we add error nodes? I can try adding them in later PR's with the current model as well.

@StephenWeatherford
Copy link
Contributor Author

It'll be easier if we wait, but thanks anyway. I'd like to handle this in a shared aware across all our extensions if possible.

@PrashanthCorp PrashanthCorp modified the milestones: 0.6.0, 0.7.0 Feb 26, 2019
@ejizba ejizba removed this from the 0.7.0 milestone May 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants