Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .venv to default .dockerignore #3476

Closed
matneh opened this issue Mar 28, 2022 · 2 comments · Fixed by #3477
Closed

Add .venv to default .dockerignore #3476

matneh opened this issue Mar 28, 2022 · 2 comments · Fixed by #3477

Comments

@matneh
Copy link

matneh commented Mar 28, 2022

Situation:
When working through the Flask tutorial in https://code.visualstudio.com/docs/python/tutorial-flask it recommends following this tutorial https://code.visualstudio.com/docs/containers/quickstart-python to discover how to containerize a python application.

In the Flask tutorial, it suggests creating a virtual environment inside the .venv directory, but in the default .dockerignore file there is an ignore for .env.

I suggest that either the docker plugin add .venv as one of its defaults in .dockerignore, OR change the Flask tutorial to recommend building a virtual environment in the .env directory.

@bwateratmsft
Copy link
Collaborator

This is a good idea. Should be quick to add to the .dockerignore template.

@bwateratmsft
Copy link
Collaborator

This is now released in version 1.22 of the Docker extension.

@microsoft microsoft locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants