Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct use of Keytar and use new SecretStorage API #2699

Closed
bwateratmsft opened this issue Feb 4, 2021 · 2 comments · Fixed by #2709
Closed

Remove direct use of Keytar and use new SecretStorage API #2699

bwateratmsft opened this issue Feb 4, 2021 · 2 comments · Fixed by #2709
Labels
engineering fix released P2
Milestone
1.11.0

Comments

@bwateratmsft
Copy link
Collaborator

In 1.53.0, VSCode added a new SecretStorage API. We currently use keytar directly. We should remove our usage of keytar in favor of the SecretStorage API.
@bwateratmsft
Copy link
Collaborator Author

Note: this same change ought to be made in the extensibility repo.

@dbreshears dbreshears added this to the 1.11.0 milestone Feb 4, 2021
@dbreshears dbreshears added the P2 label Feb 4, 2021
@bwateratmsft bwateratmsft self-assigned this Feb 8, 2021
This was referenced Feb 8, 2021
Merged
Merged
@bwateratmsft bwateratmsft removed their assignment Feb 10, 2021
@bwateratmsft
Copy link
Collaborator Author

This is now released in Docker extension version 1.11.0. Please note, due to this change users will need to reconnect to their registries (i.e. reenter their credentials).

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engineering fix released P2
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

Remove keytar in favor of VSCode API microsoft/vscode-docker
2 participants
@dbreshears @bwateratmsft