Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI Docker Debugger #2615

Closed
Kludex opened this issue Jan 9, 2021 · 7 comments · Fixed by #2740
Closed

FastAPI Docker Debugger #2615

Kludex opened this issue Jan 9, 2021 · 7 comments · Fixed by #2740

Comments

@Kludex
Copy link
Contributor

Kludex commented Jan 9, 2021

Description

As a VSCode user I want to be able to debug my FastAPI application living inside a Docker container. 🎉

More information

The web framework is growing, and I think the community will benefit from this feature. 😎

Besides, a PR was accepted on the Python VSCode extension with the same purpose, but without Docker: microsoft/vscode-python#14247

The idea is to have the option Python: FastAPI on the Docker: Initialize for Docker debugging:
image

Notes

  • I'll be working on this. I'll link the PR when I've finished. 🧑‍🏭
  • Please let me know if this feature will not be accepted, so I stop working on it 🌻
@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Jan 11, 2021

Thanks for the suggestion! As long as the Python extension supports FastAPI remote debugging (which it probably does), then this should be possible. We'll take a look.

EDIT: I had missed that you'd be working on a PR. Thanks!

@Kludex
Copy link
Contributor Author

Kludex commented Jan 11, 2021

Fwiw, it should be similar to what's on the Flask one.

Basically this: https://github.com/Kludex/fastapi-docker-debug/

@karolz-ms
Copy link
Contributor

@Kludex yes, please submit a PR, and thank you for helping us make the extension better!!

@Kludex
Copy link
Contributor Author

Kludex commented Jan 12, 2021

@karolz-ms @bwateratmsft Thank you for accepting the idea! I'll be pushing a PR in the next days.

@bwateratmsft bwateratmsft added this to the 1.10.0 milestone Jan 13, 2021
@bwateratmsft bwateratmsft modified the milestones: 1.10.0, 1.11.0 Feb 4, 2021
@bwateratmsft
Copy link
Collaborator

Hey @Kludex, any updates on this?

@Kludex
Copy link
Contributor Author

Kludex commented Feb 24, 2021

@bwateratmsft I've started. But I lost track of it.

I'll be working (and hopefully) finishing it this weekend. :)

@bwateratmsft
Copy link
Collaborator

This is now released in Docker extension version 1.11.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants