Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Codespaces] There is no prompt "Cannot edit in read-only editor" when editing a container file #2494

Closed
v-ruizh opened this issue Nov 16, 2020 · 9 comments

Comments

@v-ruizh
Copy link

v-ruizh commented Nov 16, 2020

Build Version: 20201114.1

Repro Steps:

  1. Open a container file from container view.
  2. Edit it and check the result.

Expect:
There is a prompt "Cannot edit in read-only editor".
image

Actual:
There is no prompt "Cannot edit in read-only editor".
image

@v-ruizh v-ruizh added the AT-CTI label Nov 16, 2020
@bwateratmsft
Copy link
Collaborator

I haven't been able to reproduce, the "Cannot edit in read-only editor" tag appears for me. What OS did you try on and is this VSCode Insiders?

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Nov 16, 2020

I missed that this was in Codespaces, I'll try there.

UPDATE: The "Cannot edit..." tooltip still appears for me in Codespaces too.

@v-ruizh
Copy link
Author

v-ruizh commented Nov 17, 2020

@bwateratmsft Sorry for miss the information. This issue only reproduces with remote/browser scenario. I guess you may repro it with local scenarios. You can reproduce this issue with below steps.

  1. Navigate to the source repo on GitHub.
  2. Click the “Code” button and choose “Open with Codespaces”.
  3. Click the “+ New Codespace” button.
  4. Once the GHCS is loaded, install the Docker extension and reproduce this issue.

Please feel free to let me know if you have any concern.

@bwateratmsft
Copy link
Collaborator

I did try it on Codespaces but was not able to reproduce the issue. Does it happen consistently?

@v-ruizh
Copy link
Author

v-ruizh commented Nov 18, 2020

@bwateratmsft This issue happens consistently. You can try to add something to reproduce this issue. This issue does not reproduce if you try to delete something.

@vscodebot
Copy link

vscodebot bot commented Dec 9, 2020

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Dec 9, 2020
@xkungfu
Copy link

xkungfu commented Jan 3, 2021

same issue.
why closed?

@v-ruizh
Copy link
Author

v-ruizh commented Jan 5, 2021

@bwateratmsft This issue also reproduces, reopen it. Could you help to take a look?

@bwateratmsft
Copy link
Collaborator

Ok, I was able to repro but only in the web editor and only when trying to add--it still shows when I try to delete (i.e. with Backspace). This would be an issue with VSCode and/or the web editor, not with the Docker extension. I opened microsoft/vscode#113854 for that but since this isn't very serious I'll close this issue. (Also, we plan on making the files editable anyway with #2465)

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants