Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting errors are not cleared for deleted files #237

Closed
tomasaschan opened this issue Mar 16, 2018 · 3 comments
Closed

Linting errors are not cleared for deleted files #237

tomasaschan opened this issue Mar 16, 2018 · 3 comments

Comments

@tomasaschan
Copy link

Steps to reproduce:

  1. Open a new VS Code instance with this extension installed in an empty folder
  2. Create a file called Dockerfile, but don't add any contents. You (correctly) get a linting error stating No source image provided with FROM
  3. Delete the Dockerfile

Expected behavior:

The linting error disappears from the Problems pane.

Actual behavior:

The linting error is still displayed.

Footnote:

According to the documentation for the language server protocol, it's up to the extension to clear out messages by pushing an empty array.

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 16, 2018

@tlycken Thank you very much for your bug report. I have reproduced the problem.

I will have to figure out how to detect this deletion event in the language server.

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 16, 2018

@tlycken I have opened rcjsuen/dockerfile-language-server#214 to capture this problem. I have also written up two proposed solutions there.

@rcjsuen
Copy link
Contributor

rcjsuen commented May 21, 2018

@tlycken Thanks again for the bug report. This has been fixed in the 0.0.27 release.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants