Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce outdated image check to once-per-day max #2272

Closed
bwateratmsft opened this issue Sep 3, 2020 · 2 comments · Fixed by #2321
Closed

Reduce outdated image check to once-per-day max #2272

bwateratmsft opened this issue Sep 3, 2020 · 2 comments · Fixed by #2321
Labels
enhancement fix released
Milestone
1.7.0

Comments

@bwateratmsft
Copy link
Collaborator

The new Docker Hub rate limits on pulling (100 per 6 hours for anonymous, 200 for authenticated) will be quickly consumed by the image out-of-date checking. They define a pull as up to two manifest endpoint calls. The image out-of-date check depends entirely on anonymous image manifest lookups; if I have e.g. 20 base images, then restarting VSCode just five times in six hours would completely consume my allowance.
@bwateratmsft bwateratmsft added this to the 1.6.0 milestone Sep 3, 2020
@bwateratmsft bwateratmsft changed the title Disable to remove image out-of-date check Disable or remove image out-of-date check Sep 3, 2020
@bwateratmsft bwateratmsft self-assigned this Sep 3, 2020
@bwateratmsft
Copy link
Collaborator Author

The rate limits doc mentions that HEAD requests do not count against the limit, but unfortunately there is no data in the response to a HEAD request that is useful for this purpose.

@bwateratmsft bwateratmsft mentioned this issue Sep 3, 2020
Merged
@bwateratmsft bwateratmsft changed the title Disable or remove image out-of-date check Reduce outdated image check to once-per-day max Sep 3, 2020
@bwateratmsft bwateratmsft modified the milestones: 1.6.0, 1.7.0 Sep 4, 2020
@bwateratmsft bwateratmsft mentioned this issue Sep 15, 2020
Merged
@bwateratmsft bwateratmsft removed their assignment Sep 15, 2020
@bwateratmsft
Copy link
Collaborator Author

This is now fixed in Docker extension version 1.7.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement fix released
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Check MCR images; check images at most once a day microsoft/vscode-docker
1 participant
@bwateratmsft