Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for dockerRun does not list the remove property #2268

Closed
s-truax opened this issue Aug 31, 2020 · 3 comments
Closed

Documentation for dockerRun does not list the remove property #2268

s-truax opened this issue Aug 31, 2020 · 3 comments
Labels
documentation
Milestone
1.7.0

Comments

@s-truax
Copy link

s-truax commented Aug 31, 2020

The documentation page for writing custom tasks using the Docker extension does not list remove as a property of the dockerRun object. Link.

However, this is an attribute of the RunDockerOptions interface defined in src/tasks/DockerRunTaskDefinitionBase.ts as can be seen on this line.
@bwateratmsft
Copy link
Collaborator

Good catch!

@dbreshears dbreshears added this to the 1.7.0 milestone Sep 3, 2020
@bwateratmsft
Copy link
Collaborator

We should also update the docs for #2294 at the same time as this.

@bwateratmsft
Copy link
Collaborator

Fixed this in microsoft/vscode-docs#3902.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
3 participants
@dbreshears @bwateratmsft @s-truax