Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey prompt can show up simultaneously in multiple sessions #2245

Closed
karolz-ms opened this issue Aug 20, 2020 · 2 comments · Fixed by #2266
Closed

Survey prompt can show up simultaneously in multiple sessions #2245

karolz-ms opened this issue Aug 20, 2020 · 2 comments · Fixed by #2266
Milestone

Comments

@karolz-ms
Copy link
Contributor

If multiple VS Code sessions are started at the same time (e.g. after machine restart), and the user is selected for a survey, the current implementation will pop up a survey prompt pretty much in all sessions at the same time. That can be annoying.

We could solve this by adding a random delay to the survey prompt, so that one session with shortest delay shows the prompt, and other sessions are delayed enough to "notice" the user was already prompted.

@bwateratmsft
Copy link
Collaborator

Good catch @karolz-ms. Maybe we could mix the current hardcoded delay and add a slush of +/- a few seconds?

@karolz-ms
Copy link
Contributor Author

@bwateratmsft yes, that is exactly what I had in mind

@dbreshears dbreshears added this to the 1.6.0 milestone Aug 27, 2020
@bwateratmsft bwateratmsft self-assigned this Aug 31, 2020
@bwateratmsft bwateratmsft removed their assignment Sep 8, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants