-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running docker-compose up without specifying files #223
Comments
This might have been fixed... |
Hi @millimoose, I have a couple of notes:
|
Hi, I was brought in from #186, which I'd contributed to via comments. Thanks to @PrashanthCorp for pointing me in this direction. For me, I'd consider that the order that I selected the files in, would then naturally flow into the order that the files were passed to docker-compose. As I mentioned in #186 as well, most times I've seen docker-compose files, they are naturally segregated into less-then-more specific (i.e. As to the pipeline processes, the processes we were using were set up by Visual Studio 2017's Docker project - so two (debug and release environments) - a base docker-compose and a Happy to help in any way I can :D |
Hi @PrashanthCorp, thank you for taking a look at the issue. I'll grant that I'm not familiar with the usages of Docker you bring up, I made the issue motivated by being unable to follow the pattern for splitting "production" and "development" environments that Docker itself supports out of the box by automatically defaulting to If even more varied configurations are in common use, that's all the more reason to ditch the current UI, since it's going to cover very few real-world needs. That said, in my case, I only ever needed the pipeline above, so I'd guess defining new pipelines is a rareish occurence. One aside: I don't believe you're "supposed to" (again, I don't have extensive Docker experience and real world best practices might be different) use |
I had a look at how VS does it: microsoft/DockerTools#121 (comment) The sketch addresses the issue of specifying the order of compose files. I'll go ahead and take that approach for the fix. Let me know if the above comment needs some tweaking for your use-cases. |
#1603 allows running docker-compose commands without specifying the files as input. |
Hey @millimoose , this is now available in Docker extension version 1.0.0. |
We have our docker-compose.yml files structured according to the example in the Docker configuration here: https://docs.docker.com/compose/extends/
That is, there's a
docker-compose.yml
that sets up the "production" stage, and adocker-compose.override.yml
for the "development" stage. The default behaviour for Docker Compose, when given no-f
parameters, is to use these two configuration files for commands. The idea is that in development, one only needs to rundocker-compose up
without having to remember to use a specific file, to keepdocker-compose.yml
clean of development environment concerns while reusing it as much as possible.Unfortunately it's currently impossible to fire up the containers using the plugin, because it doesn't support selecting multiple files yet (see #186); but it also doesn't seem to support selecting no configuration files which would work just as well in my case. For development it only really works if I duplicate all my configuration in a
docker-compose.dev.yml
and set that explicitly, which is a workaround I'd really like to avoid.The text was updated successfully, but these errors were encountered: