Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend outdated image checking to MCR images #2165

Closed
bwateratmsft opened this issue Jul 15, 2020 · 2 comments · Fixed by #2321
Closed

Extend outdated image checking to MCR images #2165

bwateratmsft opened this issue Jul 15, 2020 · 2 comments · Fixed by #2321
Labels
enhancement fix released
Milestone
1.7.0

Comments

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Jul 15, 2020 •
edited
Loading

Currently only docker.io/library images are checked; we should expand this to MCR images since .NET is one of the main scenarios for the extension. Additionally, .NET images seem to get updated more frequently than most (e.g. every few weeks).
@bwateratmsft
Copy link
Collaborator Author

MCR allows requests to public images with no Authorization header. For example: https://mcr.microsoft.com/v2/dotnet/aspnet/manifests/5.0

This will make it easier to implement.

@bwateratmsft bwateratmsft added this to the 1.6.0 milestone Jul 16, 2020
@dbreshears dbreshears modified the milestones: 1.6.0, 1.7.0 Aug 27, 2020
@bwateratmsft bwateratmsft self-assigned this Sep 11, 2020
@bwateratmsft bwateratmsft mentioned this issue Sep 15, 2020
Merged
@bwateratmsft bwateratmsft removed their assignment Sep 15, 2020
@bwateratmsft
Copy link
Collaborator Author

This is now fixed in Docker extension version 1.7.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement fix released
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Check MCR images; check images at most once a day microsoft/vscode-docker
2 participants
@dbreshears @bwateratmsft