Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Python project with Ctrl+F5 still hits breakpoint #2075

Closed
v-ruizh opened this issue Jun 18, 2020 · 6 comments · Fixed by #2093
Closed

Running Python project with Ctrl+F5 still hits breakpoint #2075

v-ruizh opened this issue Jun 18, 2020 · 6 comments · Fixed by #2093

Comments

@v-ruizh
Copy link

v-ruizh commented Jun 18, 2020

OS: All
Build Version: 1.3.1-alpha

Repro Steps:

  1. Open a python project(General/Django/Flask) in VS Code.
  2. Add Docker support for it.
  3. Set a breakpoint and Ctrl+F5 to run this project.

Expect:
Run the project successfully without breakpoint hit.

Actual:
It will still hits the breakpoint.

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Jun 18, 2020

Not a very serious issue IMO.

@ucheNkadiCode
Copy link
Contributor

ucheNkadiCode commented Jun 26, 2020

Not a very serious issue IMO.

I'll investigate this likely next week, but I plan to try and run each of the projects with CTRL + F5 on the regular python Launch configs for the respective languages and see if it skips over a breakpoint. Then I'll try it within our Docker launch config for each.

If I am able to repro this issue, what are the next steps?

@bwateratmsft
Copy link
Collaborator

If I am able to repro this issue, what are the next steps?

We need to decide if it's actually important enough to matter. 😄

@int19h
Copy link

int19h commented Jul 2, 2020

For Python, running with debugging can have a substantial perf penalty in some cases - it's not a cooperative runtime like .NET or Node.js, so tracing is not zero-cost even sans breakpoints.

It's probably an easy fix - check whether "noDebug" property in the debug config that you get from VSCode is propagated to debugpy adapter.

@bwateratmsft
Copy link
Collaborator

@int19h Ah, I didn't realize that was how it worked (VSCode passes a property in that we need to pass along). If so, it is probably the same underlying issue as #2024 and fixed by #2093. I'll try it out.

@bwateratmsft
Copy link
Collaborator

Yup, indeed that was the case so I'll mark this fixed by #2093.

@bwateratmsft bwateratmsft modified the milestones: 1.5.0, 1.4.0 Jul 6, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants