Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require secondary authentication on MFA enabled account #1953

Closed
conradwt opened this issue May 7, 2020 · 4 comments · Fixed by #1989
Closed

Require secondary authentication on MFA enabled account #1953

conradwt opened this issue May 7, 2020 · 4 comments · Fixed by #1989

Comments

@conradwt
Copy link

conradwt commented May 7, 2020

When I enter Docker ID and Access Token, I'm seeing the following message:

Incorrect Authentication Credentials

@conradwt
Copy link
Author

conradwt commented May 7, 2020

I was able to resolve the issue that I was having authenticating to the Docker Hub registry by using the person access token instead of the access token. There should be some additional guidance here. For example, the modal looks this way today:

Screen Shot 2020-05-07 at 2 45 32 PM

Thus, I recommend changing the wording to something similar to the following to cover the case where people are using MFA:

Enter your password or personal access token (Press 'Enter' to confirm or 'Escape' to cancel)

@bwateratmsft
Copy link
Collaborator

Similar to #1968 (which is for GitLab)

@conradwt
Copy link
Author

@bwateratmsft Actually, this issue relates to Docker and not Gitlab. Thus, these extensions shouldn't be considered the same because we are trying to authenticate against two different systems here. Next, I can use my personal access token with the VS Code Docker extension but the interface needs to change to be clear to the user. I'm sure that Gitlab extension has its own client UI and flow but I wouldn't consider the two issues the same.

@bwateratmsft
Copy link
Collaborator

They're definitely not the same--as you say, this one is for Docker Hub, the other for GitLab--but both deal with using access tokens as the secret to authenticate with instead of passwords. We probably need changes to deal with that scenario better; for example, if no username is present we will not try to authenticate at all, but access tokens often do not need a username associated.

@dbreshears dbreshears added this to the 1.3.0 milestone May 15, 2020
@dbreshears dbreshears added the P2 label May 15, 2020
@bwateratmsft bwateratmsft removed their assignment May 20, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants