Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js: Investigate using "node-user" by default #1834

Closed
bwateratmsft opened this issue Apr 8, 2020 · 3 comments · Fixed by #3115
Closed

Node.js: Investigate using "node-user" by default #1834

bwateratmsft opened this issue Apr 8, 2020 · 3 comments · Fixed by #3115

Comments

@bwateratmsft
Copy link
Collaborator

Investigate using "node-user" in the container by default. Of course, Node ecosystem is huge so this won't work all the time, but probably will most of the time.

Related to #1766.

@bwateratmsft bwateratmsft added this to the 1.2.0 milestone Apr 10, 2020
@dbreshears dbreshears modified the milestones: 1.2.0, 1.3.0 Apr 14, 2020
@dbreshears dbreshears modified the milestones: 1.3.0, Future May 12, 2020
@ucheNkadiCode ucheNkadiCode modified the milestones: Future, 1.16.0 Jul 20, 2021
@ucheNkadiCode
Copy link
Contributor

This is necessary for writing our troubleshooting document for VS Code Docker extension

@bwateratmsft
Copy link
Collaborator Author

I'd like to hear what @philliphoff thinks. It's almost a certainty that some apps/packages are not going to work as non-root. However, that raises two questions--how common of a problem do we think it will be? Also...do we care? Obviously requiring root permissions is usually a bad idea and I wouldn't feel so badly about being incompatible with some of them.

@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Aug 16, 2021

This has been released in Docker extension version 1.16.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants