Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper templating engine for scaffolded files #1617

Closed
philliphoff opened this issue Feb 12, 2020 · 5 comments · Fixed by #2267
Closed

Use proper templating engine for scaffolded files #1617

philliphoff opened this issue Feb 12, 2020 · 5 comments · Fixed by #2267

Comments

@philliphoff
Copy link
Member

philliphoff commented Feb 12, 2020

The text definition/manipulation we use to scaffold files (e.g. Docker files) is...not pretty. It'd be nice to move to a proper templating engine to get the inline strings into separate files and stop cluttering up the actual scaffolding logic.

I don't have a huge preference on any particular template engine; we're using Handlebars in another extension and it seems to work reasonably well.

@bwateratmsft edit: From @conradwt in #2026:

Goal
I would like to be able to add additional languages as well as customize existing languages for my development workflows without having to submit a PR to update the extension.
Currently
The supported languages are fixed and new customizations need to be redeployed within a future version of this extension.
Possible Solution
Extend the extension to allow users to add their own templates to a designated directory that would get picked up and displayed within VS Code when one uses Docker Add command.

@bwateratmsft
Copy link
Collaborator

I'd almost consider this feature work, not just engineering...

@philliphoff
Copy link
Member Author

@bwateratmsft Almost added the feature label but, technically, it wouldn't have any visibility to users, which is the sort of thing I tend to put in the "engineering" bucket.

@bwateratmsft
Copy link
Collaborator

Can't it have visibility though? I can see users wanting ways to offer their own templates, through settings or otherwise.

@philliphoff
Copy link
Member Author

Well, yes, adding user-customization the Docker-related files would be a new feature. Having "real" templates on disk rather than embedded inline is likely to make that easier, but that I wouldn't consider that the initial goal.

@bwateratmsft
Copy link
Collaborator

This is now released in Docker extension 1.6.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants