-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper templating engine for scaffolded files #1617
Comments
I'd almost consider this feature work, not just engineering... |
@bwateratmsft Almost added the feature label but, technically, it wouldn't have any visibility to users, which is the sort of thing I tend to put in the "engineering" bucket. |
Can't it have visibility though? I can see users wanting ways to offer their own templates, through settings or otherwise. |
Well, yes, adding user-customization the Docker-related files would be a new feature. Having "real" templates on disk rather than embedded inline is likely to make that easier, but that I wouldn't consider that the initial goal. |
This is now released in Docker extension 1.6.0. |
The text definition/manipulation we use to scaffold files (e.g. Docker files) is...not pretty. It'd be nice to move to a proper templating engine to get the inline strings into separate files and stop cluttering up the actual scaffolding logic.
I don't have a huge preference on any particular template engine; we're using Handlebars in another extension and it seems to work reasonably well.
@bwateratmsft edit: From @conradwt in #2026:
The text was updated successfully, but these errors were encountered: