Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Functionality to the image Push command #1595

Closed
ucheNkadiCode opened this issue Jan 30, 2020 · 1 comment · Fixed by #1783
Closed

Add Functionality to the image Push command #1595

ucheNkadiCode opened this issue Jan 30, 2020 · 1 comment · Fixed by #1783

Comments

@ucheNkadiCode
Copy link
Contributor

Problem: I believe that the push command could do a better job of handling untagged images. Currently, when a user tries to push an untagged image with no Default Registry set, the image is pushed to docker.io/library which is likely to be denied. Even if a default registry is set, the user is prompted to tag their image before pushing it and then must click Tag. Image shown below

image

My proposal: If an image isn't already tagged with a strict registry path, I believe clicking the push command should trigger the command pallete in which the user can select a container registry from any of the registries they are connected to and have the option of creating an ACR (if they are connected to Azure) if they don't have one already. This will help the user tag their image properly before pushing it to their registry of choice.

@dbreshears dbreshears added this to the 0.11.0 milestone Jan 31, 2020
@dbreshears dbreshears modified the milestones: 0.11.0, 0.12.0 Feb 10, 2020
@bwateratmsft
Copy link
Collaborator

We should also handle login when possible/practical.

@bwateratmsft bwateratmsft self-assigned this Mar 12, 2020
@bwateratmsft bwateratmsft linked a pull request Mar 24, 2020 that will close this issue
@dbreshears dbreshears added the P1 label Mar 25, 2020
@bwateratmsft bwateratmsft removed their assignment Mar 30, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants