Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing Image to Registry of Choice #1539

Closed
ucheNkadiCode opened this issue Jan 9, 2020 · 1 comment · Fixed by #1783
Closed

Pushing Image to Registry of Choice #1539

ucheNkadiCode opened this issue Jan 9, 2020 · 1 comment · Fixed by #1783

Comments

@ucheNkadiCode
Copy link
Contributor

When pushing an image, there is no option or prompt to push the image to a specific registry. Either the image is pushed to default or, in the case of Azure Container Registry, the user is required to tag their image rigidly (someusername.azurecr.io/someexpressapp:latest) to override the default registry selection. I believe it should be made easier for a user push an image tagged in any manner to their registry of choice.

This experience could be improved by having a "Push Default" and "Push to..." option. "Push Default" would behave just like the current push command. "Push to" would open a dialog to select which registry the user wants to use and optionally set a default.

@karolz-ms
Copy link
Contributor

@ucheNkadiCode note that tagging the image before pushing it to a repository is how Docker works. In other words, tagging is an essential part of sharing an image via a repository. E.g. see https://docs.docker.com/engine/reference/commandline/tag/ (last paragraph of the topic).

Since a tag is always required, we need to think what Push to... operation would exactly entail. I.e. would it always involve creating new tag, or maybe allow the user to choose from a set of existing tags that point to external repositories?

@bwateratmsft bwateratmsft self-assigned this Mar 13, 2020
@bwateratmsft bwateratmsft linked a pull request Mar 24, 2020 that will close this issue
@dbreshears dbreshears added the P1 label Mar 24, 2020
@bwateratmsft bwateratmsft removed their assignment Mar 30, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants