Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure local images are up to date #1409

Closed
dbreshears opened this issue Nov 8, 2019 · 4 comments · Fixed by #1490
Closed

Ensure local images are up to date #1409

dbreshears opened this issue Nov 8, 2019 · 4 comments · Fixed by #1490
Assignees
Milestone

Comments

@dbreshears
Copy link
Member

No description provided.

@dbreshears dbreshears added this to the 0.10.0 milestone Nov 8, 2019
@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Nov 8, 2019

We have the dockerBuild.pull flag today on docker-build tasks; if true it is equivalent to using --pull. Currently it is treated as false if unspecified, but we can change that.

@philliphoff
Copy link
Member

We should continue to treat unspecified as false, but we should instead scaffold pull to true in new tasks.

@eine
Copy link

eine commented Dec 15, 2019

We should continue to treat unspecified as false, but we should instead scaffold pull to true in new tasks.

Since the default behaviour in docker is false, I think it should be better kept like that.

@philliphoff
Copy link
Member

Since the default behaviour in docker is false, I think it should be better kept like that.

Thanks for the feedback. We've had discussions related to this behavior in Visual Studio, too, but users there seem to prefer the images kept up to date despite the Docker CLI's defaults, hence our wanting to copy that behavior in VS Code as well. Scaffolding pull to true for new tasks is a bit of a compromise over simply changing the interpretation of omitting the value on a task; it also allows for changing our minds if VS Code users end up preferring the opposite behavior.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants