Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option in config to pull base image when build dockerfile #1211

Closed
kattunga opened this issue Aug 15, 2019 · 3 comments
Closed

add an option in config to pull base image when build dockerfile #1211

kattunga opened this issue Aug 15, 2019 · 3 comments

Comments

@kattunga
Copy link

Please,
add a config option to add the --pull parameter when build dockerfile.
Now there is no option to pull and update base images.

Another option could be a second menu entry in context menu with this option so we could have:
Build Image...
Build Image (pull base image)...

@bwateratmsft
Copy link
Collaborator

This is a good suggestion, thanks!

@bwateratmsft
Copy link
Collaborator

@EricJizbaMSFT @sgreenmsft @fiveisprime @PrashanthCorp @philliphoff

For .NET Core debugging in particular, I think it would make sense for there to be a "pull" argument in the "docker build" section, defaulting to true. This would help the common stale image issues.

For the right click -> Build Image scenario, I think we could do either a configuration option, or have two commands like @kattunga suggests. Any thoughts?

@bwateratmsft
Copy link
Collaborator

Resolved in #1245

@bwateratmsft bwateratmsft added this to the 0.9.0 milestone Sep 18, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants