Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] "docker.showExplorer" setting in Explorer 2.0 #1014

Closed
ejizba opened this issue Jun 18, 2019 · 3 comments
Closed

[Discussion] "docker.showExplorer" setting in Explorer 2.0 #1014

ejizba opened this issue Jun 18, 2019 · 3 comments

Comments

@ejizba
Copy link
Contributor

ejizba commented Jun 18, 2019

I removed this setting when I did Docker Explorer 2.0:

"docker.showExplorer": {
          "type": "boolean",
          "default": true,
          "description": "Show or hide the Explorer"
        },

but I wanted to file an issue to discuss if/how we should support that before releasing. I see some value in having a VS Code setting to control this, but it's already possible to hide views if you right click on them.

But that begs the question - do we have one setting for all views and a setting per view? For example:

docker.showExplorer
docker.images.showExplorer
docker.containers.showExplorer

Or should we flip the wording:

docker.hideExplorer
docker.images.hideExplorer
docker.containers.hideExplorer
@ejizba ejizba added this to the 0.7.0 milestone Jun 18, 2019
@fiveisprime
Copy link
Member

My initial thought is that the setting is unnecessary given how the new explorer windows work. It feels natural to modify the UI using the context menus that are already available.

What is the experience for customers how have the extension installed with the explorer hidden using the setting who take the this update?

@chrisdias
Copy link
Member

I think the docker.showExplorer setting is a hangover from way before extensions could create viewlets, and right click hide/show. So removing it is fine.

My $0.02 on the other settings, I would wait for feedback that people want to control the explorer visibility through settings rather than right click.

@ejizba ejizba modified the milestones: 0.7.0, Future Jul 1, 2019
@StephenWeatherford
Copy link
Contributor

StephenWeatherford commented Jul 1, 2019 via email

@bwateratmsft bwateratmsft removed this from the Future milestone Nov 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants