Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlinks that point to a parent folder can cause duplicate directory iteration and parsing on Windows #6864

Closed
sean-mcmanus opened this issue Jan 28, 2021 · 5 comments
Closed

Symlinks that point to a parent folder can cause duplicate directory iteration and parsing on Windows #6864

sean-mcmanus opened this issue Jan 28, 2021 · 5 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix symlinks
Milestone
1.3.0

Comments

@sean-mcmanus
Copy link
Contributor

With a single .cpp and symlink, it gets parsed 20 times (the max recursive depth).
@sean-mcmanus sean-mcmanus added this to the 1.3.0 milestone Jan 28, 2021
@sean-mcmanus sean-mcmanus self-assigned this Jan 28, 2021
@sean-mcmanus sean-mcmanus mentioned this issue Jan 28, 2021
Closed
@sean-mcmanus sean-mcmanus added fixed Check the Milestone for the release in which the fix is or will be available. quick fix labels Jan 29, 2021
@Colengms Colengms modified the milestones: 1.3.0, 1.2.1 Feb 17, 2021
@Colengms
Copy link
Contributor

@sean-mcmanus Did this make it into 1.2.1 ?

@sean-mcmanus
Copy link
Contributor Author

No, the change is bundled into my bigger symlink PR that is dealing with files.exclude stuff.

@sean-mcmanus sean-mcmanus removed the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 13, 2021
@sean-mcmanus
Copy link
Contributor Author

It's fixed but it's currently bundled into a PR with the other symlink changes (which aren't finished yet).

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Apr 5, 2021
@sean-mcmanus sean-mcmanus removed their assignment Apr 5, 2021
@michelleangela
Copy link
Contributor

Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/1.3.0-insiders4

@michelleangela
Copy link
Contributor

Fix is released in the 1.3.0 release version https://github.com/microsoft/vscode-cpptools/releases/tag/1.3.0

@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix symlinks
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@sean-mcmanus @michelleangela @Colengms