Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler path with spaces produces error #5215

Closed
ivankravets opened this issue Mar 27, 2020 · 4 comments · Fixed by #5217
Closed

Compiler path with spaces produces error #5215

ivankravets opened this issue Mar 27, 2020 · 4 comments · Fixed by #5217
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix regression A bug that didn't exist in a previous release
Milestone
0.27.0

Comments

@ivankravets
Copy link

Related topic https://community.platformio.org/t/platform-io-compiler-error/12684

  1. We provide a full path to the compiler using compilerPath option
  2. This a path option, so we do not do any modifications because arguments are passed to compilerArgs

Yes, we can escape compilerPath by default but it looks like a bug.

Thanks!

/cc @valeros @sean-mcmanus
@ivankravets ivankravets changed the title Compiler path with spaces produces errors Compiler path with spaces produces error Mar 27, 2020
@sean-mcmanus sean-mcmanus self-assigned this Mar 27, 2020
@sean-mcmanus sean-mcmanus added this to the 0.27.0 milestone Mar 27, 2020
@sean-mcmanus sean-mcmanus added bug Feature: Configuration An issue related to configuring the extension or IntelliSense Language Service quick fix regression A bug that didn't exist in a previous release labels Mar 27, 2020
@sean-mcmanus
Copy link
Contributor

This issue existed for a "long time" (i.e. in 0.26.3), but the error squiggling was disabled by default in 0.26.3 and 0.27.0-insiders5 fixed that.

@sean-mcmanus sean-mcmanus mentioned this issue Mar 27, 2020
Merged
@sean-mcmanus
Copy link
Contributor

Thanks a lot for reporting this. It's fixed by #5217 for our 0.27.0 release (planned for Monday).

@sean-mcmanus sean-mcmanus removed their assignment Mar 27, 2020
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 28, 2020
@ivankravets
Copy link
Author

Thank you so much! The most important release for our community!

@sean-mcmanus
Copy link
Contributor

Fixed with 0.27.0.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix regression A bug that didn't exist in a previous release
Projects
None yet
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Fix incorrect compiler path with spaces and args squiggle. microsoft/vscode-cpptools
2 participants
@ivankravets @sean-mcmanus