Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error squiggles appear with VS Code Insiders if "(" or ")" is in the path #4505

Closed
sean-mcmanus opened this issue Oct 29, 2019 · 3 comments
Closed

No error squiggles appear with VS Code Insiders if "(" or ")" is in the path #4505

sean-mcmanus opened this issue Oct 29, 2019 · 3 comments
Labels
bug Language Service regression A bug that didn't exist in a previous release Visual Studio Code Caused by (or depends on changes from) VS Code
Milestone
Tracking

Comments

@sean-mcmanus
Copy link
Contributor

Root cause is a VS Code Insider change...not sure if we need to fix this ourselves yet.
@sean-mcmanus sean-mcmanus added bug Language Service regression A bug that didn't exist in a previous release Visual Studio Code Caused by (or depends on changes from) VS Code labels Oct 29, 2019
@sean-mcmanus sean-mcmanus added this to the Tracking milestone Oct 29, 2019
This was referenced Oct 29, 2019
Closed
Closed
@Colengms
Copy link
Contributor

@sean-mcmanus , Is the issue that VS Code now encodes all URI's in a new way? If so, we should encode the same way when converting from path to URI. Or, is the issue that VS Code is giving us inconsistent encodings for URIs? The later would seem to be a VS Code bug.

@sean-mcmanus
Copy link
Contributor Author

From what I saw, the Insiders version encodes URIs differently from the non-Insiders (not 100% if there are inconsistent cases)...but our extension would need to behave correctly for both cases somehow.

@sean-mcmanus
Copy link
Contributor Author

Latest VS Code Insiders has it fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Language Service regression A bug that didn't exist in a previous release Visual Studio Code Caused by (or depends on changes from) VS Code
Projects
None yet
Milestone
Tracking
Development

No branches or pull requests
2 participants
@sean-mcmanus @Colengms