extension opens system header instead of project header

[flip111]

Type: LanguageService

Describe the bug

• OS and Version: Ubuntu 19.04
• VS Code Version: 1.33.1
• C/C++ Extension Version: 0.25.1
• Other extensions you installed (and if the issue persists after disabling them): antlr4

I opened this folder in vscode /home/flip111/spksrc/distrib/gcc-9.2.0. I saw that this folder was created /home/flip111/spksrc/distrib/gcc-9.2.0/.vscode.

When i look at the file /home/flip111/spksrc/distrib/gcc-9.2.0/libiberty/obstack.c i go to a symbol press F12 and it opens the file /usr/include/obstack.h.

I expect it to open /home/flip111/spksrc/distrib/gcc-9.2.0/include/obstack.h.

In the configuration GUI the includePath is set to ${workspaceFolder}/**, compiler configured to /usr/bin/clang

It's my first time using vscode, i don't understand why it prefers to open my system header instead of the project header.

[sean-mcmanus]

Are you using Go to Def on the #include <obstack.h>? If so, then it's bug #2564 .

Otherwise, can you run C/C++: Log Diagnostics and look what the includePath is being used and see if the paths are correct?

[flip111]

I use it on chunkfun in

https://github.com/gcc-mirror/gcc/blob/gcc-9_2_0-release/libiberty/obstack.c#L92

-------- Diagnostics - 10/10/2019, 2:36:45 AM
Version: 0.25.1
Current Configuration:
{
    "name": "Linux",
    "includePath": [
        "${workspaceFolder}/**"
    ],
    "defines": [],
    "compilerPath": "/usr/bin/clang",
    "cStandard": "c11",
    "cppStandard": "c++17",
    "intelliSenseMode": "clang-x64"
}
Translation Unit Mappings:
[ /home/flip111/spksrc/distrib/gcc-9.2.0/include/obstack.h ]:
    /home/flip111/spksrc/distrib/gcc-9.2.0/include/obstack.h
[ /home/flip111/spksrc/distrib/gcc-9.2.0/libiberty/obstack.c ]:
    /home/flip111/spksrc/distrib/gcc-9.2.0/libiberty/obstack.c
Translation Unit Configurations:
[ /home/flip111/spksrc/distrib/gcc-9.2.0/include/obstack.h ]:
    Process ID: 11540
    Memory Usage: 13 MB
    Compiler Path: /usr/bin/clang
    Includes:
        /usr/include/c++/8
        /usr/include/x86_64-linux-gnu/c++/8
        /usr/include/c++/8/backward
        /usr/lib/llvm-8/lib/clang/8.0.0/include
        /usr/local/include
        /usr/include/x86_64-linux-gnu
        /usr/include
    Standard Version: c++17
    IntelliSense Mode: clang-x64
    Other Flags:
        --clang
        --clang_version=80000
        --header_only_fallback
[ /home/flip111/spksrc/distrib/gcc-9.2.0/libiberty/obstack.c ]:
    Process ID: 11744
    Memory Usage: 21 MB
    Compiler Path: /usr/bin/clang
    Includes:
        /usr/local/include
        /usr/lib/llvm-8/lib/clang/8.0.0/include
        /usr/include/x86_64-linux-gnu
        /usr/include
    Standard Version: c11
    IntelliSense Mode: clang-x64
    Other Flags:
        --clang
        --clang_version=80000
Total Memory Usage: 34 MB

[sean-mcmanus]

Your includePath doesn't include any workspace folder path. What is your workspace folder? The "${workspaceFolder}/**" will only recursively find headers that are under that path -- is the header in a parent path of the workspace folder?

[flip111]

Hi @sean-mcmanus i don't really understand what you are saying. You say my includePath doesn't include a workspace folder path. But i see in the logs:

    "includePath": [
        "${workspaceFolder}/**"
    ],

${workspaceFolder}/** looks like a workspace folder path to me. Do you mean a path additionally to this path?

I was assuming that ${workspaceFolder} would be the directory which the .vscode directory is located which in my case is /home/flip111/spksrc/distrib/gcc-9.2.0 (here the .vscode directory is in).

The header file is located here /home/flip111/spksrc/distrib/gcc-9.2.0/include/obstack.h. Which is UNDER the workspace path. But it's NOT a in a PARENT directory like /home/flip111/spksrc/distrib or /home/flip111/spksrc or /home/flip111 or /home.

[bobbrow]

Does your compiler exist in the /home/flip111/spksrc/distrib/gcc-9.2.0 folder?
(for example: /home/flip111/spksrc/distrib/gcc-9.2.0/bin/g++)

If it does, you should change the "compilerPath" to point to it instead of using /usr/bin/clang.

[flip111]

There are no binaries distributed along with the source code of gcc. See https://github.com/gcc-mirror/gcc/tree/gcc-9_2_0-release

[bobbrow]

Thanks for the update. This is one of the tricky corner cases we face when we find includes with duplicate names. You should be able to set priority on your local copy of the includes by adding "/home/flip111/spksrc/distrib/gcc-9.2.0/include" to the "includePath" array like this:

    "includePath": [
        "${workspaceFolder}/include",
        "${workspaceFolder}/**"
    ],

[flip111]

Thanks @bobbrow that fixed it. May i note that this is not very intuitive, imo project files should get priority. The issue can be closed if wontfix. Or leave open to change priority of include files and/or add help information about this.

[Colengms]

Closing this as the user's issue is addressed, and the behavior is currently by design. We improved the logging when multiple headers with the same name are encountered.