Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom config provider extension users should not see the message "Please update your includePath." #3971

Closed
sherryyshi opened this issue Jun 5, 2019 · 1 comment · Fixed by #5406
Assignees
Labels
bug Feature: Extension API fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@sherryyshi
Copy link
Contributor

Currently when an include search path does not resolve, the message displayed to users is "#include error detected. Please update your includePath." This message is not helpful for custom configuration providers, since we don't want the users to update the includePath themselves, which would override the results the config provider provides.

In our scenario, the user would see this every time at start up since it takes a few seconds for the makefile parsing to complete. In this case, we especially don't want the users to be updating any configurations on their own.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jun 6, 2019

We have a custom/different message for compile_commands -- looks like a custom message for custom config providers was just an oversight.

This is actually a bug with the C/C++ extension and not the API (https://github.com/microsoft/vscode-cpptools/issues) -- not sure if we should move it.

@bobbrow bobbrow transferred this issue from microsoft/vscode-cpptools-api Jul 24, 2019
@bobbrow bobbrow added this to the 1.0 milestone Mar 27, 2020
@bobbrow bobbrow modified the milestones: 0.28.0, 0.29.0 May 1, 2020
@elahehrashedi elahehrashedi modified the milestones: 0.29.0, 0.28.0 May 4, 2020
@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label May 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Extension API fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants