Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliSense squiggles don't update after a header is renamed #3670

Closed
sean-mcmanus opened this issue May 20, 2019 · 3 comments
Closed

IntelliSense squiggles don't update after a header is renamed #3670

sean-mcmanus opened this issue May 20, 2019 · 3 comments
Assignees
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

After a header is renamed that is used in a source, the IntelliSense squiggles don't update to reflect the change. In some cases, the even editing/save the file doesn't pick up the changes from the rename, i.e. the file in the #include <> no longer exists, but IntelliSense doesn't complain about it -- it seems like it's using some cached version of the non-existent file.

I hit this while doing the repro of #3378 and renaming headers_test.h.

So this might be 2 bugs:

  1. The rename should auto-trigger an update squiggles without having to edit/save (i.e. non-existent file becomes existent).
  2. The rename should clear the IntelliSense process cache of the file if the file doesn't exist any more.
@bobbrow
Copy link
Member

bobbrow commented Apr 2, 2020

We'll be looking at this as part of the code folding work. Note this will address files located within the workspace. We don't get notifications for files outside the workspace.

@Colengms
Copy link
Contributor

I've addressed the issue of the intelliSense process not being notified of files changed outside of the editor. (VS Codes informs us of a rename as a delete and a create, provided it's in the workspace). It looks like we also need to trigger squiggle updates.

@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label May 1, 2020
@elahehrashedi
Copy link
Contributor

This issue is fixed in 0.28.0.
0.28.0 release: https://github.com/microsoft/vscode-cpptools/releases/tag/0.28.0

@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

4 participants