Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] It would be better to change the "Database" to "database" in the input box #2198

Closed
v-xinda opened this issue Oct 9, 2023 · 2 comments
Closed

[Suggestion] It would be better to change the "Database" to "database" in the input box #2198

v-xinda opened this issue Oct 9, 2023 · 2 comments
Labels
AT-CTI Created by CTI team ⛔ won't fix The issue is not critical enough to be worked on.
Milestone
0.21.0

Comments

@v-xinda
Copy link

v-xinda commented Oct 9, 2023

OS: All
Build Version: 20231007.1
Regression: Not a regression

Repro steps:

  1. F1 -> Click "Cosmos DB: Delete Document...".
  2. Check the tip in the input box.

Actual:
Show "Select resource" tip in the input box.
Screenshot 2023-10-09 at 15 24 01

Suggestion:
It would be better to change the "resource" to "Resource" in the input box. Like below:
Screenshot 2023-10-09 at 15 24 13

More Info:
This issue also reproduces when more than one subscription is selected.
Screenshot 2023-10-09 at 15 27 29
@v-xinda v-xinda added the AT-CTI Created by CTI team label Oct 9, 2023
@MicroFish91
Copy link
Contributor

I personally prefer the non-branded resource names to be lower-case. I do agree that we should be consistent about this though

@MicroFish91 MicroFish91 changed the title [Suggestion] It would be better to change the "resource" to "Resource" in the input box [Suggestion] It would be better to change the "Database" to "database" in the input box Oct 18, 2023
@MicroFish91 MicroFish91 added this to the 0.21.0 milestone Oct 18, 2023
@JasonYeMSFT
Copy link
Contributor

The string is pulled from the childTypeLabel of the database node's AzExtTreeItem object by the utils package. Since this is a minor issue and changing the value of childTypeLabel may carry unknown impact, let's not worry about this string for now.

@JasonYeMSFT JasonYeMSFT added the ⛔ won't fix The issue is not critical enough to be worked on. label Feb 20, 2024
@microsoft microsoft locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
AT-CTI Created by CTI team ⛔ won't fix The issue is not critical enough to be worked on.
Projects
None yet
Milestone
0.21.0
Development

No branches or pull requests
3 participants
@JasonYeMSFT @MicroFish91 @v-xinda