Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icon for run all failed tests #78

Closed
luabud opened this issue Jul 30, 2021 · 3 comments
Closed

Add new icon for run all failed tests #78

luabud opened this issue Jul 30, 2021 · 3 comments
Assignees
Milestone

Comments

@luabud
Copy link
Member

luabud commented Jul 30, 2021

Hey there! Now that there will be a "Test: Rerun Failed Tests" command, I was wondering if we could have a new official icon (perhaps updated to the vscode-icons repo, if it's not too much work) that we could display on the test explorer (only when there is at least one failed test in the view)?

We have custom ones at https://github.com/microsoft/vscode-python/blob/main/resources/dark/run-failed-tests.svg and https://github.com/microsoft/vscode-python/blob/main/resources/light/run-failed-tests.svg, but we figured it'd be best to have something provided "officially" by VS Code

@miguelsolorio miguelsolorio transferred this issue from microsoft/vscode Aug 2, 2021
@miguelsolorio miguelsolorio added this to the August 2021 milestone Aug 2, 2021
@miguelsolorio
Copy link
Contributor

How about this?

CleanShot 2021-08-16 at 11 02 09@2x

This also maps with our other run icons:

CleanShot 2021-08-16 at 11 02 27@2x

@luabud
Copy link
Member Author

luabud commented Aug 16, 2021

@misolori I love it!

cc @karthiknadig

@miguelsolorio
Copy link
Contributor

CleanShot 2021-08-19 at 15 10 51@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants