Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GH icon request #67

Closed
Tyriar opened this issue Jun 9, 2021 · 5 comments
Closed

New GH icon request #67

Tyriar opened this issue Jun 9, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2021

GH just came out with some new icons, we should update ours and add the new ones https://github.blog/changelog/2021-06-08-new-issue-and-pull-request-state-icons/

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jun 9, 2021
@miguelsolorio
Copy link
Contributor

I think if we are missing some we can add but I don't think we need to update existing ones as we've created our own style with codicons. Are there any specific icons you are thinking about?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 9, 2021

We should align with their icons as they're the new way they show up in github. Otherwise users need to know 2 different symbols for open and closed issues for example?

@miguelsolorio
Copy link
Contributor

Ah ok I see what you mean now. Yes, in that case I do think updating those make sense.

@miguelsolorio
Copy link
Contributor

Updated the following icons:

  • issue-closed now points to pass
  • issue-draft
  • git-pull-request-closed
  • git-pull-request-draft

CleanShot 2021-07-07 at 11 19 58@2x

CleanShot 2021-07-07 at 11 20 09@2x

@Tyriar
Copy link
Member Author

Tyriar commented Jul 7, 2021

FYI @alexr00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants