Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for left-heavy flame graph view #23

Closed
connor4312 opened this issue Sep 9, 2020 · 7 comments
Closed

Icon for left-heavy flame graph view #23

connor4312 opened this issue Sep 9, 2020 · 7 comments
Assignees
Labels
new icon Requests for new icons published Icons has been added to library

Comments

@connor4312
Copy link
Member

connor4312 commented Sep 9, 2020

In https://github.com/microsoft/vscode-js-profile-visualizer/issues/11 the flame graph now supports a 'left-heavy' view, where callstacks are grouped and sorted by the cumulative time taken, rather than being displayed chronologically. I didn't find a good icon to use for it in our existing codicons.

Speedscope uses a simple arrow, but this is not self-explanitory:

Something like the generic chart icon rotated clockwise 180 degrees would work nicely https://iconmonstr.com/chart-4-svg/

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Sep 9, 2020

We do have this graph icon:

image

So something like this?

image

@connor4312
Copy link
Member Author

connor4312 commented Sep 9, 2020

Yep, the left version -- since the flame graph is oriented vertically

@miguelsolorio
Copy link
Contributor

Ahhh, that makes sense now. I can add this in shortly.

@connor4312
Copy link
Member Author

connor4312 commented Sep 9, 2020

Maybe with a small arrow on the left end of the line to indicate the action of 'compacting' the graph? Might be too small to be visible though

@miguelsolorio
Copy link
Contributor

We could do something like where the arrow is part of the top line? Might be hard to see at smaller sizes though:

image

Here's @ 100%

image

@connor4312
Copy link
Member Author

awesome!

@miguelsolorio
Copy link
Contributor

Fixed via dd1edb2. This is now graph-left in codicons 0.0.9.

@miguelsolorio miguelsolorio added published Icons has been added to library new icon Requests for new icons labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Requests for new icons published Icons has been added to library
Projects
None yet
Development

No branches or pull requests

2 participants