From e08c34f07c838acdd2f681ecd22a774f5ccff45a Mon Sep 17 00:00:00 2001 From: Fatima Qarni Date: Wed, 24 Jul 2024 13:48:10 -0700 Subject: [PATCH] check for quick start in select configure preset to prevent second configure --- CHANGELOG.md | 1 + src/presetsController.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 64f084ff5..3767c9a8f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ Bug Fixes: - Fix re-using a terminal for launching even when the environment has changed. [#3478](https://github.com/microsoft/vscode-cmake-tools/issues/3478) - Don't require Ninja or Make on command line when checking for supported generators. [#3924](https://github.com/microsoft/vscode-cmake-tools/issues/3924) - Fix our keybindings for debug and run without debugging to better match VS Code. [#3507](https://github.com/microsoft/vscode-cmake-tools/issues/3507) +- Prevent second configure after `QuickStart` if the `automaticReconfigure` setting is enabled. [#3910](https://github.com/microsoft/vscode-cmake-tools/issues/3910) ## 1.18.43 diff --git a/src/presetsController.ts b/src/presetsController.ts index 8feca7962..cd8c06da1 100644 --- a/src/presetsController.ts +++ b/src/presetsController.ts @@ -892,7 +892,7 @@ export class PresetsController { await this.setConfigurePreset(chosenPreset); } - if (this.project.workspaceContext.config.automaticReconfigure) { + if (this.project.workspaceContext.config.automaticReconfigure && !quickStart) { await this.project.configureInternal(ConfigureTrigger.selectConfigurePreset, [], ConfigureType.Normal); } return !addPreset || allPresets.length === 0;