Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build log always shows source directory even when using out of source builds #3308

Closed
an3l opened this issue Aug 21, 2023 · 3 comments
Closed
Assignees
Labels
bug a bug in the product Feature: build help wanted we currently are not planning work on this and would like help from the open source community quick fix the fix is estimated to be quick suggested Temporary label for internal tracking for suggested bugs to pick up in spare time.
Milestone

Comments

@an3l
Copy link

an3l commented Aug 21, 2023

Brief Issue Summary

When build the project using out of source build directory (vscode-build ), log still shows source directory (10.11 below)

[main] Building folder: 10.11
[build] Starting build
[proc] Executing command: /usr/local/bin/cmake --build /home/anel/GitHub/mariadb/server/build/vscode-build --config Debug --target all --

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

From file cmakeProject.js can be seen that only current folderName is used (source directory). It should be binaryDir IMHO.

Suggested fix should be

log.info(localize('run.build', 'Building folder: {0}', this.binaryDir ? this.binaryDir : this.folderName ), (targets && targets.length > 0) ? targets.join(', ') : '');
@gcampbell-msft
Copy link
Collaborator

Thanks for the heads up! I'll mark this as a bug and tag it. We welcome OSS contribution and would greatly appreciate you contributing this fix!

@gcampbell-msft gcampbell-msft added bug a bug in the product help wanted we currently are not planning work on this and would like help from the open source community Feature: build labels Aug 23, 2023
@gcampbell-msft gcampbell-msft added this to the 1.16 milestone Aug 23, 2023
@microsoft microsoft deleted a comment from github-actions bot Sep 7, 2023
@benmcmorran benmcmorran modified the milestones: 1.16, 1.17 Nov 14, 2023
@github-project-automation github-project-automation bot moved this to Triage Needed in CMake Tools Nov 29, 2023
@gcampbell-msft gcampbell-msft moved this from Triage Needed to Pending Prioritization in CMake Tools Nov 29, 2023
@gcampbell-msft gcampbell-msft modified the milestones: 1.17, On Deck Nov 29, 2023
@gcampbell-msft gcampbell-msft added quick fix the fix is estimated to be quick suggested Temporary label for internal tracking for suggested bugs to pick up in spare time. labels Apr 24, 2024
@andreeis andreeis self-assigned this May 19, 2024
@gcampbell-msft
Copy link
Collaborator

Closed, fixed in #3778

@github-project-automation github-project-automation bot moved this from Pending Prioritization to Completed in CMake Tools Jun 24, 2024
@an3l
Copy link
Author

an3l commented Jun 24, 2024

@gcampbell-msft I forgot about this to contribute, glad to see it is fixed.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the product Feature: build help wanted we currently are not planning work on this and would like help from the open source community quick fix the fix is estimated to be quick suggested Temporary label for internal tracking for suggested bugs to pick up in spare time.
Projects
Status: Completed
Development

No branches or pull requests

5 participants