Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake Tools should choose the version of cmake.exe from the newest VS installation when cmake.cmakePath is unspecified #2753

Closed
bobbrow opened this issue Sep 22, 2022 · 0 comments · Fixed by #2909
Closed

CMake Tools should choose the version of cmake.exe from the newest VS installation when cmake.cmakePath is unspecified #2753

bobbrow opened this issue Sep 22, 2022 · 0 comments · Fixed by #2909
Milestone
On Deck

Comments

@bobbrow
Copy link
Member

bobbrow commented Sep 22, 2022

Brief Issue Summary

If a user is dependent on the cmake.exe that ships with Visual Studio to configure their project, we should make sure that it is the latest version (or the one that matches the active kit). The code in paths.ts exits as soon as it finds a cmake + ninja combo.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response
@bobbrow bobbrow added this to the On Deck milestone Sep 22, 2022
@bobbrow bobbrow mentioned this issue Dec 27, 2022
Merged
@bobbrow bobbrow linked a pull request Dec 27, 2022 that will close this issue
Choose CMake from the newest VS installation when not found elsewhere #2909
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
On Deck
Development

Successfully merging a pull request may close this issue.

Choose CMake from the newest VS installation when not found elsewhere microsoft/vscode-cmake-tools
1 participant
@bobbrow