Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require vscode 1.41.0 to match dotnet install extension requirement #618

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Require vscode 1.41.0 to match dotnet install extension requirement #618

merged 1 commit into from
Apr 18, 2020

Conversation

StephenWeatherford
Copy link
Contributor

Fixes #614

alexgav
alexgav approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenWeatherford StephenWeatherford merged commit 83432a7 into rel/0.9.2 Apr 18, 2020
@StephenWeatherford StephenWeatherford deleted the saw/update-required-vscode branch April 18, 2020 18:20
@StephenWeatherford StephenWeatherford mentioned this pull request Apr 20, 2020
Closed
StephenWeatherford added a commit that referenced this pull request Apr 28, 2020
@StephenWeatherford
Require vscode 1.41.0 to match dotnet install extension requirement (#…
7795429 
…618)
StephenWeatherford added a commit that referenced this pull request Apr 28, 2020
@StephenWeatherford
[0.10.0] Use new dotnet acquisition extension (#599)
1039aa6 
* Use new dotnet acquisition extension

* Install .net extension for tests (#607)

* Install .net install extension for tests

* Fix tests

* Reset to 3.0, fix files not included

* fix lint

* Require vscode 1.41.0 to match dotnet install extension requirement (#618)

* Update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgav alexgav alexgav approved these changes

@bhsubra bhsubra Awaiting requested review from bhsubra

@neilpeterson neilpeterson Awaiting requested review from neilpeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.2 (Use dotnet acquisition extension)
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenWeatherford @alexgav