Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion list for "location" shows incorrect icons #676

Closed
neilpeterson opened this issue May 6, 2020 · 1 comment
Closed

Completion list for "location" shows incorrect icons #676

neilpeterson opened this issue May 6, 2020 · 1 comment
Labels
bug extension fix released in progress P2
Milestone
0.11.0 Nested tem...

Comments

@neilpeterson
Copy link
Contributor

neilpeterson commented May 6, 2020 •
edited
Loading

image

Expected (from JSON and 0.6.0 release):

image

From internal 987484
@StephenWeatherford
Copy link
Contributor

AFTER:
image
image
image
Note that the first two cases are different in vscode JSON. But the VS code which we're using doesn't differentiate these two cases, thus I wasn't able to give them separate icons.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug extension fix released in progress P2
Projects
None yet
Milestone
0.11.0 Nested templates
Development

No branches or pull requests
2 participants
@StephenWeatherford @neilpeterson