Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision comparison states unexpected problems #601

Closed
nielsvdc opened this issue Apr 15, 2020 · 4 comments · Fixed by #866
Closed

Revision comparison states unexpected problems #601

nielsvdc opened this issue Apr 15, 2020 · 4 comments · Fixed by #866

Comments

@nielsvdc
Copy link

I have a ARM file that contains comments. When I save changes for this file, go to the Source Control pane and click the file, I get a comparison between the saved changes and the current revision in source control.
When I look at the editor window for the current revision, I see unexpected problems that should not be there.

  • Comments are not permitted in JSON
  • String does not match the pattern of "^[-\w._()]+$"

See attached test file and a screenshot of the errors and windows.

test.txt

vscode_errors

@StephenWeatherford
Copy link
Contributor

Turns out git uses a separate scheme "git" that we're not registering for.

@StephenWeatherford
Copy link
Contributor

I can no longer see this on vscode insiders Version: 1.47.0-insider. I think they stopped showing errors in the left-hand pane, which is good (the errors you were getting were from the JSON language service, which should not be enabled for ARM templates).

@nielsvdc
Copy link
Author

@StephenWeatherford I just tried with vscode 1.47.0 and with 1.48.0-insider and I still get the same problem notifications.

@StephenWeatherford
Copy link
Contributor

Okay, I am seeing them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants