Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Present resource apiVersion in reverse chronological order #489

Closed
neilpeterson opened this issue Feb 13, 2020 · 4 comments · Fixed by #1279
Closed

Present resource apiVersion in reverse chronological order #489

neilpeterson opened this issue Feb 13, 2020 · 4 comments · Fixed by #1279
Assignees
@alexgav @StephenWeatherford
Labels
enhancement fix released language server P1
Milestone
0.15.1

Comments

@neilpeterson
Copy link
Contributor

Gathered from internal feedback.

On apiVersion intellisens, present the list in reverse chronological order so that the most recent is at the top of the list.

image
@StephenWeatherford
Copy link
Contributor

https://dev.azure.com/devdiv/DevDiv/_boards/board/t/ARM%20Template%20Authoring/Stories/?workitem=1069201

@neilpeterson neilpeterson changed the title [Suggestion] Present resource apiVersion in reverse chronological order Present resource apiVersion in reverse chronological order Apr 12, 2020
@StephenWeatherford StephenWeatherford modified the milestones: 0.12.0, 0.13.0 Jul 29, 2020
@StephenWeatherford StephenWeatherford modified the milestones: 0.13.0, 0.14.0 Oct 8, 2020
@StephenWeatherford
Copy link
Contributor

We create completion items for apiVersions in GetApiVersionValuesCompletionItemsAsync of src\Languages\json\Editor\Arm\AsyncCompletion\ArmResourceTypeAndVersionCompletionProvider.cs

I think the easiest way to reverse-sort those would be to create non-empty sortText that would be reverse of what the "normal" completion item sort would be.

@StephenWeatherford StephenWeatherford removed this from the 0.14.0 milestone Nov 9, 2020
@MarcusFelling MarcusFelling modified the milestones: 0.15.0, 0.15.1 Mar 8, 2021
@StephenWeatherford
Copy link
Contributor

fixed by #1276

@StephenWeatherford
Copy link
Contributor

Not fixed?

@StephenWeatherford StephenWeatherford mentioned this issue Apr 9, 2021
Merged
@ghost ghost added the In PR Has a PR that will fix this issue when merged label Apr 9, 2021
@ghost ghost added fixed in next release and removed In PR Has a PR that will fix this issue when merged labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgav alexgav

@StephenWeatherford StephenWeatherford

Labels
enhancement fix released language server P1
Projects
None yet
Milestone
0.15.1
Development

Successfully merging a pull request may close this issue.

Show apiVersions in reverse chronological microsoft/vscode-azurearmtools
4 participants
@alexgav @MarcusFelling @StephenWeatherford @neilpeterson