Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete list for apiVersions on child resources is empty #351

Closed
bmoore-msft opened this issue Oct 25, 2019 · 8 comments
Closed

autocomplete list for apiVersions on child resources is empty #351

bmoore-msft opened this issue Oct 25, 2019 · 8 comments
Assignees
Labels

Comments

@bmoore-msft
Copy link
Contributor

If I have a child resource and on the apiVersion property try to bring up the completion list an empty list is returned, e.g.

  "resources": [
    {
      "type": "subnets",
      "apiVersion": "",

I suspect because we're looking for an exact type match - we'd need to include parent type when building the list.

@StephenWeatherford
Copy link
Contributor

This no longer repros, although I'm not sure if the list that we get is correct.

@neilpeterson
Copy link
Contributor

Here is a demo which seems to confirm @bmoore-msft assumption. I might also assume that if the child resource does not have a matching apiVersion, the list may be empty.

image

image

When decoupled, the child resource returns all potential apiVersions.

image

@neilpeterson
Copy link
Contributor

Update on this one. The code updates have been completed. We will test soon and have the fix in the next release.

@StephenWeatherford
Copy link
Contributor

@neilpeterson This is fixed, too, right? Please close.

@neilpeterson
Copy link
Contributor

Yep, fixed.

@StephenWeatherford
Copy link
Contributor

Just FYI, we've had some issues with the Azure schema CDN and some other things that have delayed this release. Will have it out as soon as possible, hopefully next week.

@neilpeterson
Copy link
Contributor

Fix went out today with this fix, thanks.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants