Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for template validations with extendedLocation property #1374

Open
StephenWeatherford opened this issue Sep 20, 2021 · 16 comments

Comments

@StephenWeatherford
Copy link
Contributor

{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
    "contentVersion": "1.0.0.0",
    "parameters": {},
    "functions": [],
    "variables": {},
    "resources": [
        {
            "name": "publicIPAddress1",
            "type": "Microsoft.Network/publicIPAddresses",
            "apiVersion": "2020-11-01",
            "location": "[resourceGroup().location]",
            "tags": {
                "displayName": "publicIPAddress1"
            },
            "extendedLocation": {
                "name": "abc",
                "type": "EdgeZone"
            },
            "properties": {
                "publicIPAllocationMethod": "Dynamic",
                "dnsSettings": {
                    "domainNameLabel": "dnsname1"
                }
            }
        }
    ],
    "outputs": {}
}

Template validation error:

Template validation failed: Could not find member 'extendedLocation' on object of type 'TemplateResource'. Path 'resources[0].extendedLocation', line 16, position 31.
@StephenWeatherford
Copy link
Contributor Author

Blocked because we need changes in the validation assembly

@ucheNkadiCode
Copy link

@StephenWeatherford This makes sense! So this extra attribute came in as a breaking change to the schema validation. Thank you!

@junczhan
Copy link

junczhan commented Jan 6, 2022

@StephenWeatherford Is the issue fixed?

@StephenWeatherford
Copy link
Contributor Author

Unfortunately not yet, it's owned by another team and so is complicated.

@StephenWeatherford
Copy link
Contributor Author

We need upvotes from anyone who's affected by this in order to push getting this fixed.

@JunchenZ
Copy link

JunchenZ commented Jan 7, 2022

@StephenWeatherford Azure Portal's new Virtual Network Create experience will be affected (the work is in progress and expected to be done & published soon)

@JunchenZ
Copy link

no update for two months

@JunchenZ
Copy link

could anyone have an update on the issue as it is blocking us from doing template deployment on vs code?

@alex-frankel
Copy link
Member

Is this failing when the template is actually deployed, or only throwing an error in the ARM Tools VS Code extension? If it is the former, then @JunchenZ can you open a support ticket? If it's the latter, it shouldn't be affecting the portal deployment experience.

@JunchenZ
Copy link

@alex-frankel it's the latter

@alex-frankel
Copy link
Member

Have you attempted to deploy this template in the portal? Were you blocked there? I think this is a legitimate issue and we should keep it open, but want to confirm that you are not blocked.

@JunchenZ
Copy link

i was using the txt file format to avoid the vs code error, but when i test it, arm gave me error saying the localhost uri is not accepted, it need a public accessible uri, i don't know how to get a public uri of my file which is added to my repo

@alex-frankel
Copy link
Member

alex-frankel commented Mar 23, 2022

That seems like a separate error from the extendedLocation property error. Can you share more details of what you are deploying? Is it possible to share the code, the error message, and the repro steps in depth?

@StephenWeatherford
Copy link
Contributor Author

(And preferably in a new issue unless it's actually related to the extendedLocation false positive, thanks.)

@StephenWeatherford
Copy link
Contributor Author

Blocked by #1458

@JunchenZ
Copy link

@alex-frankel it's may be unrelated to this, could ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants