Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The opened "Azure Cloud Shell (Bash)" terminal looks a little ugly after switching Authentication Library #380

Closed
v-ruizh opened this issue Dec 3, 2021 · 3 comments · Fixed by #527
Labels
AT-CTI Created by CTI team P1
Milestone

Comments

@v-ruizh
Copy link

v-ruizh commented Dec 3, 2021

OS: All
Build Version: 20211130.7
Regression: Not a regression

Repro Steps:

  1. Set the "Azure: Authentication Library" setting to "ADAL".
  2. Open a "Azure Cloud Shell (Bash)" terminal.
  3. Change the "Azure: Authentication Library" setting to "MSAL"
  4. Click "Sign Out and Reload Window" button in the opened notification to take effect Authentication Library change.
  5. Check the above opened "Azure Cloud Shell (Bash)" terminal.

Expect:
The opened "Azure Cloud Shell (Bash)" terminal looks well.

Actual:
The opened "Azure Cloud Shell (Bash)" terminal looks a little ugly.
image

@v-ruizh v-ruizh added the AT-CTI Created by CTI team label Dec 3, 2021
@wwlorey
Copy link
Contributor

wwlorey commented Dec 8, 2021

This also repros when you refresh the VS Code window without changing auth libraries.

I dug into this and unfortunately we can't do much about it ☹️ We provide aTerminalProfile to VS Code which it uses to create a Terminal. The problem is: once the terminal is created and the window refreshes we don't have access to that terminal from the extension so we can't catch this "socket hang up" error and show a better one.

@wwlorey
Copy link
Contributor

wwlorey commented Dec 10, 2021

Once VS Code supports opting out of persistent terminals we can fix this. We would just mark all of our terminals as non-persistent so when the window is refreshed that terminal is no longer shown. Tracking in microsoft/vscode#118726

@wwlorey wwlorey reopened this Dec 10, 2021
@wwlorey wwlorey added this to the Tracking milestone Dec 10, 2021
@wwlorey wwlorey modified the milestones: Tracking, Backlog Candidates Jan 28, 2022
@wwlorey wwlorey added the P1 label Jan 28, 2022
@wwlorey
Copy link
Contributor

wwlorey commented Jan 28, 2022

This is coming soon: microsoft/vscode#139112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT-CTI Created by CTI team P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants