Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oatpp-swagger] Feature/oatpp swagger 1.3.0 latest #42349

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mechatheo
Copy link

This adds the version oatpp-swagger 1.3.0-latest since 1.4.0 is still not ready, and this already brings an important feature, you can set the BASE_URL for the auto generated swagger routes.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@mechatheo
Copy link
Author

mechatheo commented Nov 25, 2024

@microsoft-github-policy-service agree company="Alfred Kärcher SE & Co. KG"

1 similar comment
@mechatheo
Copy link
Author

@microsoft-github-policy-service agree company="Alfred Kärcher SE & Co. KG"

@@ -1,6 +1,6 @@
{
"name": "oatpp-swagger",
"version": "1.3.0",
"version": "1.3.0-latest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, 1.3.0-latest is older than 1.3.0, so this will not have the sort order you want: https://learn.microsoft.com/vcpkg/users/versioning#version-semver

I filed oatpp/oatpp-swagger#95 against upstream to ask them to reconsider

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not like the sketchy version either, it also made it necessary to stip the suffix off the version in the port cmake file to fit the extracted file name... so this is clearly would be cleaner 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update, I closed the swagger issue and opened against the main repo instead, which has the same problem: oatpp/oatpp#988

@BillyONeal BillyONeal added the depends:upstream-changes Waiting on a change to the upstream project label Nov 25, 2024
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 26, 2024
@jimwang118 jimwang118 changed the title Feature/oatpp swagger 1.3.0 latest [oatpp-swagger] Feature/oatpp swagger 1.3.0 latest Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants