-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mxml] New Port #39991
base: master
Are you sure you want to change the base?
[mxml] New Port #39991
Conversation
Do note that this PR is incomplete. I don't really know what I'm doing here, so any docs and extra help and info appreciated. Most of what's written here is copied from other ports. |
What's with the license fail? |
@Rossmaxx Thanks for this PR. I think we need to ask upstream whether to add it to vcpkg. In this way, I can help you complete this PR. :) |
I did ask about this upstream some time ago, and here's what the maintainer said. Forgot that i asked this in the first place. michaelrsweet/mxml#281 (comment) I initially asked for cmake support but the maintainer refused. It's after some time that I understand that vcpkg doesn't require ports to be in cmake and other build systems being supported. I personally need this port for a project which I'm involved with. I'm trying to add msvc support for a previously mingw built application. For my use case, I am thinking of disabling linux ports as I don't really want to deal with pkg config here. I'll update the vckpg.json when i start working on this again. I'm on a small break now. But i would like to collect as much info on this break. Thanks for your reply. |
"version": "3.3.1", | ||
"homepage": "https://github.com/michaelrsweet/mxml", | ||
"description": "A tiny xml parsing library", | ||
"license": "Apache license 2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"license": "Apache license 2.0" | |
"license": "Apache-2.0" |
(I don't understand the comments about upstream. No patches, no restriction, no need to ask.) |
fixes: #19042
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.