-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x264 build failure - /usr/bin/bash -j invalid option #8473
Comments
not correct it must be ? |
I have the same error and have been looking into working around it. -j is an option for make, but is being passed into bash instead. The issue stems from scripts/cmake/vcpkg_build_make.cmake lines 55 and 57-58, where the make command is being set in the options. When the make command is assembled on line 124, it sticks in some extra options in the wrong spot. line 124: I changed line 55 to: line 57-58 to:
This gets around the error, though it might be better to move the -j option to MAKE_OPTS instead of subverting the options and adding it willy-nilly like it currently does. Sadly, the build still fails when trying to do the rename on line 37 of the portfile.cmake for x254
The error is
I find this odd because the |
I just updated vcpkg and - out of curiousity - tried to install x264, now getting the same error message as @oracleoftroy: For x86-windows:
For x64-windows:
The "tools" directory stays empty during the building process, neither an "x264" subfolder nor an x264.exe are present there at any time, so I honestly don't know why the rename command fails. Maybe "copy" would be better here? |
After updating vcpkg, getting the same problem here. Stdout
|
|
Just ran into the same problem and looking forward to the fix |
Hi @timautry, thanks for reporting this issue. Thanks. |
Thank you @JackBoosY - works great on both latest builds of VS2017 and VS2019 - super work and I appreciate it very much. Take care and have a wonderful week!!! |
I'm coming across a similar error message when trying to build x264. Let me know if I should post this as a new issue, I suspect it will be an easy fix as I am a novice and unfamiliar with compilers. OS: Windows 10 1909 C:\vcpkg-master> .\vcpkg install x264 Call Stack (most recent call first): Error: Building package x264:x86-windows failed with: BUILD_FAILED Additionally, attach any relevant sections from the log files above. |
@VFoV Can you make sure your vcpkg is latest? |
Hello, I re-cloned vcpkg from the github page, re-ran the boostrapping and integration then ran .\vcpkg update. I then ran the x264 install again and got this error: Starting package 68/79: x264:x64-windows |
Hello, I'm back to this topic because I run into the very same issue as described by @VFoV when trying to build x264 x86 / x64 via vcpkg, here're the error messages: x86-windows:
x64-windows:
It looks as if configure arguments were passed to link.exe instead, but apparently the src itself is flawed: I tried to build the program using my personal MSYS2 installation and x86 failed with exactly the same "No C compiler found" error when running ./configure, while the x64 build succeeded. Maybe x264 does not support 32-bit builds in the first place? But even if that would be true it would unfortunately not explain why the x64-windows build also fails with vcpkg. Find all my logs attached, thank you! -- Edit -- I apparently was wrong with my assumptions, the src is fine, but you have to pass the correct --host triplet argument to configure, which is either i686-w64-mingw32 for x86 or x86_64-w64-mingw32 for x64, because config.guess does not get them right, at least not the 32-bit one in my case. So the actual culprit is the resp. portfile.cmake, which specifies configure options which do not exist for this particular x264 configure script. Check yourself by running ./configure --help, you won't find any of the specified options in the list. This obviously leads to the errors we encounter, as shown here:
All these options actually are "unknown" to the x264 configure script used in the src package which vcpkg downloads, so it's just logical that it has to fail in finding an appropriate compiler. |
In config.log:
@Neumann-A Could you please take a look? Thanks. |
Only have After changing
|
I think #11836 should fix this issue. |
Looks good, let's hope for the best. Thank you all very much! |
I close, I no longer use product. |
Well, but other people, e.g. myself still do, you know? So please don't stop working on a fix, many thanks! |
@Christsnatcher Anyway, I'm still tracking this issue. |
@JackBoosY Thank you very much, that's really appreciated. |
Host Environment
-OS: Windows 10 1903 18362.388
-Compiler: VS2017 v15.9.16 and VS2019 v16.3.2
To Reproduce
Steps to reproduce the behavior:
./vcpkg install x264
(My default triplet is x64-windows and vcpkg is built using the -win64 option)
Failure logs
-Cut and past the appropriate build messages from the console output.
This is the same for both VS2017 and VS2019 except for the vcpkg directory
SYSTEM@ANDROMEDA 10/06/2019 18:30:59 D:\Git\vs2019
->vcpkg install x264
The following packages will be built and installed:
x264[core]:x64-windows
Starting package 1/1: x264:x64-windows
Building package x264[core]:x64-windows...
-- Using cached D:/Git/vcpkg.downloads/mirror-x264-303c484ec828ed0d8bfe743500e70314d026c3bd.tar.gz
-- Using source at D:/Git/vs2019/buildtrees/x264/src/14d026c3bd-bca2ebf740
-- Using generator make
-- Acquiring MSYS Packages...
-- Acquiring MSYS Packages... OK
-- Configuring x64-windows-dbg
-- Configuring x64-windows-rel
-- Acquiring MSYS Packages...
-- Acquiring MSYS Packages... OK
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
Command failed: D:/Git/vcpkg.downloads/tools/msys2/msys64/usr/bin/bash.exe --noprofile --norc -c -j 17 make
Working Directory: D:/Git/vs2019/buildtrees/x264/x64-windows-dbg
See logs for more information:
D:\Git\vs2019\buildtrees\x264\build-x64-windows-dbg-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_build_make.cmake:123 (vcpkg_execute_build_process)
scripts/cmake/vcpkg_install_make.cmake:24 (vcpkg_build_make)
ports/x264/portfile.cmake:33 (vcpkg_install_make)
scripts/ports.cmake:94 (include)
Error: Building package x264:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with
.\vcpkg update
, thensubmit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: x264:x64-windows
Vcpkg version: 2019.09.12-nohash
Additionally, attach any relevant sections from the log files above.
build-x64-windows-dbg-err.log
-Please attach any additional failure logs mentioned in the console output.
Additional context
This is from the latest vcpkg "git pull" from git to my two different VCPKG roots, one for VS2017 and one for VS2019, performed at ~ 18:00 US Eastern Time.
The text was updated successfully, but these errors were encountered: