Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] How to handle C++17-only upgrades? #5337

Closed
zhihaoy opened this issue Feb 8, 2019 · 3 comments
Closed

[Question] How to handle C++17-only upgrades? #5337

zhihaoy opened this issue Feb 8, 2019 · 3 comments
Labels
category:question This issue is a question

Comments

@zhihaoy
Copy link
Contributor

zhihaoy commented Feb 8, 2019

The next release of PEGTL (3.0.0) is going to do C++17 only. How do we handle that upgrade? Ignore users with older toolchains, keeping two versions in ports tree side by side, or what.

@vicroms vicroms added the category:question This issue is a question label Feb 8, 2019
@vicroms
Copy link
Member

vicroms commented Feb 19, 2019

The current preference in vcpkg, is to have only one port per library, and that usually means only keeping the latest release available.

However, if you feel that a large portion of the userbase won't be able to upgrade; having two different ports would be the best way to handle it (e.g.: pegtl for the latest, pegtl-27 for the pre-C++17-only version).

An example would be OpenCV which currently has a port for version 3, with a PR in progress to move the current port to opencv3 and have opencv install version 4.

@vicroms vicroms closed this as completed Feb 19, 2019
@vicroms vicroms reopened this Feb 19, 2019
@zhihaoy
Copy link
Contributor Author

zhihaoy commented Feb 19, 2019

Sounds good. I'll let library authors decide whether to keep an older version under pegtl-27 or so.

@zhihaoy zhihaoy closed this as completed Feb 19, 2019
@d-frey
Copy link

d-frey commented Feb 28, 2019

Major version 3 will be incompatible with previous versions, but we are planning to offer a migration guide as well as keeping changes limited and not breaking our users unnecessarily.

We would like to keep an older release of major version 2 around for people stuck with older compilers, e.g. VS2015. We would like the old package to be named pegtl-2 (not pegtl-27), as this keeps the option of a 2.8.x maintenance release if necessary.

(Major version 3.x is not yet released, we are still working on some final changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

No branches or pull requests

3 participants