Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[podofo] update to 0.10.0 #31578

Closed
playgithub opened this issue May 23, 2023 · 11 comments · Fixed by #31584
Closed

[podofo] update to 0.10.0 #31578

playgithub opened this issue May 23, 2023 · 11 comments · Fixed by #31584
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@playgithub
Copy link
Contributor

playgithub commented May 23, 2023

Library name

podofo

New version number

0.10.0

Other information that may be useful (release notes, etc...)

current version 0.9.8
0.10.0 is not compatible with 0.9.8

@playgithub playgithub added the category:port-update The issue is with a library, which is requesting update new revision label May 23, 2023
@FrankXie05 FrankXie05 self-assigned this May 23, 2023
@FrankXie05
Copy link
Contributor

@playgithub Currently podofo has two sources, one is sourceforge and the other is Github.
Only Github has been updated to version 0.10.0, and vcpkg currently uses sourceforge.

vcpkg_from_sourceforge(

Is giehub official? Is there any difference between these two?

@playgithub
Copy link
Contributor Author

It says

Development of PoDoFo has been moved to GitHub: https://github.com/podofo/podofo

at https://sourceforge.net/projects/podofo/

@FrankXie05
Copy link
Contributor

@playgithub Thanks, I will transfer podofo to vcpkg_from_github. :)

@playgithub
Copy link
Contributor Author

Thanks

BTW, it might break many applications that depend on 0.9.x, because the API in 0.10.0 changes a lot.

@FrankXie05
Copy link
Contributor

@playgithub I'll submit a PR to see if we can fix these dependencies.

@playgithub
Copy link
Contributor Author

I mean many applications depends on podofo 0.9.x will fail to build when podofo updates to 0.10.0

@FrankXie05
Copy link
Contributor

All right, thanks for your answer. :)
A small question: should we stop updating this port due to downstream dependencies.
Can you clarify which applications depend on 0.9 and consider whether it can be migrated? 🫤

@playgithub
Copy link
Contributor Author

playgithub commented May 23, 2023

A small question: should we stop updating this port due to downstream dependencies.

I'm going to use podofo, but not yet, so my suggestion is to update it.

Can you clarify which applications depend on 0.9 and consider whether it can be migrated?

I think almost every application that depends on 0.9 will fail to build with 0.10.0

Check https://github.com/podofo/podofo/releases

The release is complete re-imagination of PoDoFo 0.9.x API in C++17, and it's API/ABI incompatible with the previous releases.

@FrankXie05
Copy link
Contributor

FrankXie05 commented May 23, 2023

@playgithub In order to ensure the api problem, I will ask the upstream whether the api will be fixed in the future. If the migration of the api is something that must be done, the downstream must also make changes. 🫤
https://github.com/podofo/podofo/wiki/PoDoFo-API-migration-guide/#098---0100

BTW, I saw some issues about api incompatibility upstream. I have a hunch that it will not be an easy task.

@FrankXie05
Copy link
Contributor

Reopen this issue for update.

@FrankXie05 FrankXie05 reopened this May 23, 2023
@playgithub
Copy link
Contributor Author

playgithub commented May 23, 2023

If the migration of the api is something that must be done, the downstream must also make changes.

Fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants