Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between vcpkg_configure_cmake and vcpkg_cmake_configure #23248

Closed
sandercox opened this issue Feb 23, 2022 · 1 comment · Fixed by #23259
Closed

Differences between vcpkg_configure_cmake and vcpkg_cmake_configure #23248

sandercox opened this issue Feb 23, 2022 · 1 comment · Fixed by #23259
Assignees
Labels
category:question This issue is a question

Comments

@sandercox
Copy link
Contributor

Describe the bug

In PR #18156 I fixed some architecture handling in both these files. My understanding is that vcpkg_cmake_configure is the new method moving forward.

In PR #20885 I notice that the scrips of vcpkg_configure_cmake has been audited and much of our changes have been replaced by using vcpkg_list commands instead of regular CMake list commands.

Is this now just waiting for vcpkg_cmake_configure to be audited as well? Or should I just make a PR for changing this and keeping these parts of the code the same?

@JonLiu1993 JonLiu1993 self-assigned this Feb 24, 2022
@JonLiu1993 JonLiu1993 added the category:question This issue is a question label Feb 24, 2022
@JonLiu1993 JonLiu1993 assigned JackBoosY and unassigned JonLiu1993 Feb 24, 2022
@JackBoosY
Copy link
Contributor

Please feel free to open a PR for script audit, these two functions should be in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants