Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libarchive] wrapper emits warnings and uses find_dependency #20182

Closed
Neumann-A opened this issue Sep 15, 2021 · 1 comment · Fixed by #20146
Closed

[libarchive] wrapper emits warnings and uses find_dependency #20182

Neumann-A opened this issue Sep 15, 2021 · 1 comment · Fixed by #20146
Assignees
@JackBoosY
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Neumann-A
Copy link
Contributor

related issue about the warning:
https://gitlab.kitware.com/vtk/vtk/-/issues/18308

also the wrapper uses find_dependency instead of find_package which only works correctly in *config.cmake
@dg0yt
Copy link
Contributor

dg0yt commented Sep 15, 2021

also the wrapper uses find_dependency instead of find_package which only works correctly in *config.cmake

I noticed when looking at #16845. I might pick this up for #20146.

For lz4, I see you are already have the details in the vtk issue. An interesting puzzle indeed.

@dg0yt dg0yt mentioned this issue Sep 15, 2021
Merged
4 tasks
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Sep 16, 2021
@JackBoosY JackBoosY linked a pull request Sep 16, 2021 that will close this issue
[libarchive,lz4] Fix pc file, modernize portfile #20146
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libarchive,lz4] Fix pc file, modernize portfile dg0yt/vcpkg
3 participants
@dg0yt @Neumann-A @JackBoosY